fibercrypto / fibercrypto/fibercryptowallet
Confusing design of the wallets and addresses models.
- Dominant language
- Go
- Stars
- 29
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
I'm coding the C++ version of the model that shows wallets and its addresses in the main page, and I realize that:
* In the walletsModel.go (https://github.com/fibercrypto/fibercryptowallet/blob/fb9e9d3455a254b9202d24ab8af689fbb6db083d/src/models/walletsModel.go#L50), there's a `QWallet` type.
* In the addressesModel.go (https://github.com/fibercrypto/fibercryptowallet/blob/fb9e9d3455a254b9202d24ab8af689fbb6db083d/src/models/addressesModel.go#L41), there's a `QAddress` type.
But despite a wallet has a list of addresses, there's no connection between them but a `walletId` property in the `QAddress` type, and a `QWallet` does not have such property, so this whole design makes no sense to me.
**Describe the solution you'd like**
* A C++ `WalletsModel` that contains a list of `Wallet` types that contains an `AddressesModel` type containing the list of `Address` types related to that wallet.
_It's there any problem with this implementation?_
Contributor guide
Assessment
This issue has not been assessed yet.