bfs_encrypt is unsafe
Open
enhancement
help wanted
- Dominant language
- Perl
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
`bfs_encrypt` just XORs the given password char for char with the corresponding char from the FHEM unique id (like 2a95084455f63205c3be85e728760f55). But the FHEM unique id is not a secret and accessible to everybody on a host (644 for `FHEM/FhemUtils/uniqueID` which contains the unique id also). XOR is only a sufficient encryption algorithm for one time pads, which the unique is most definitely not.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.