festim-dev / festim-dev/FESTIM

Change of variable method incorrect with transient temperature

Open
#956 0 comments 0 reactions 0 assignees View on GitHub
bug fenicsx
Dominant language
Python
Stars
135
Forks
45
Avg merge
3d 23h
Merged PRs (30d)
14

Description

https://github.com/festim-dev/FESTIM/blob/ccf59be02e8c993e4b6990dce690ee835a58e926/src/festim/problem_change_of_var.py#L61-L62

This should be

```python
K_S = vol.material.get_solubility_coefficient(
self.mesh.mesh, self.temperature_fenics, spe
)
K_S_n = vol.material.get_solubility_coefficient(
self.mesh.mesh, self.temperature_fenics_previous, spe
)
c = u * K_S
c_n = u_n * K_S_n
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.