festim-dev / festim-dev/FESTIM

QoL: simplify `Settings.transient` and `Settings.final_time`

Open
#847 1 comment 0 reactions 0 assignees View on GitHub
enhancement fenicsx good first issue
Dominant language
Python
Stars
135
Forks
45
Avg merge
3d 23h
Merged PRs (30d)
14

Description

https://github.com/festim-dev/FESTIM/blob/31864c86690750ab854942c82110c3f711187246/festim/settings.py#L63-L65

It can be annoying to have to set both the arguments `final_time` and `transient` as it is kind of redundant.
If we provide a final time, then obviously the simulation is transient.

We could simplify this by removing the `transient` argument altogether and replace it by a property attribute of `Settings`.

```python
@property
def transient(self):
return self.final_time is not None
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.