festim-dev / festim-dev/FESTIM-workshop
Meshes: use markers to define FESTIM subdomains for better readability
Open
- Dominant language
- Jupyter Notebook
- Stars
- 29
- Forks
- 12
- Avg merge
- 1d 35m
- Merged PRs (30d)
- 1
Description
in [Mesh with GMSH](https://festim-workshop.readthedocs.io/en/latest/content/meshes/mesh_gmsh.html#festim-model-setup), currently subdomains are defined using raw numerical value for the id:
`tube_surf = F.SurfaceSubdomain(id=7)`
It makes it non-obvious from a learner perspective that this is the way we are mapping the subdomains to their location in the mesh.
-> use the marker variables defined above (`inlet_marker`, `outlet_marker`,...) directly instead of their numerical value:
`tube_surf = F.SurfaceSubdomain(id=obstacle_marker)`
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.