feross / feross/simple-peer

When Simple-peer ICECOMPLETE_TIMEOUT is set to 1000 milliseconds Webtorrent performs MUCH faster

Open
#896 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.8k
Forks
983
PR merge metrics
No merged PRs in 30d

Description

**What version of this package are you using?**

Webtorrent v1.8.26

**What operating system, Node.js, and npm version?**

Win10 with brave:

[Version 1.41.100 Chromium: 103.0.5060.134 (Official Build) (64-bit)](https://brave.com/latest/)

**What happened?**

Client never connects faster than 5.5 seconds, until ICECOMPLETE_TIMEOUT is set to a different value like 1000, in which case client will connect within 1.5 seconds.

**What did you expect to happen?**

I would expect the client to connect as fast as possible.

**Are you willing to submit a pull request to fix this bug?**

Maybe. I'm pointing this bug out so that others hitting this issue can find this bug report.

Reference points:

https://github.com/feross/simple-peer/blob/f1a492d1999ce727fa87193ebdea20ac89c1fc6d/index.js#L11

https://github.com/feross/simple-peer/blob/f1a492d1999ce727fa87193ebdea20ac89c1fc6d/index.js#L596

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.