feross / feross/simple-peer

Segfault when creating and destroying peer with wrtc on node

Open
#887 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.8k
Forks
983
PR merge metrics
No merged PRs in 30d

Description

**What version of this package are you using?**

9.11.1

**What operating system, Node.js, and npm version?**

ubuntu 22.04
node 18.0.0
npm 8.6.0
yarn 1.22.17

**What happened?**

When creating a `Peer` with `wrtc` under node and calling `.destroy()` on that peer, node segfaults. A small reproducing example can be found here: https://github.com/soenkehahn/simple-peer-bug

**What did you expect to happen?**

The peer should be destroyed successfully.

**Are you willing to submit a pull request to fix this bug?**

I have no idea what causes this. So I'd appreciate some debugging help. If it's an easy fix, I'd be willing to provide a PR.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.