feross / feross/simple-peer

peer.addStream(stream) doesn't raise event one other peer

Open
#840 3 comments 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.8k
Forks
983
PR merge metrics
No merged PRs in 30d

Description

using: v9.11.0
library directly referenced:

peer.addStream(stream) call on the initiator peer doesn't raise peer.on('stream', ...) event on the other peer after successful data connection. When stream is passed through the initiator peer constructor, the event does get raised. I was expecting the same to happen when peer.addStream(stream) was called in situations where the stream is no yet known at peer construction time.

Also when inspecting the 'peer' object in the console, after the peer.addStream() is called, the "streams" prop, which is an array, still has a length of 0. No stream is added. Probably a regression bug.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.