feross / feross/simple-peer

peer.signal() should return a promise

Open
#593 0 comments 5 reactions 0 assignees View on GitHub
feature request
Dominant language
JavaScript
Stars
7.8k
Forks
983
PR merge metrics
No merged PRs in 30d

Description

Since setting local or remote description is an asynchronous operation, we should probably change `peer.signal()` and maybe `peer.negotiate()` too to become asynchronous and return a `Promise`.
This will help in case of tweaking `RTCRtpSender`s after negotiation to change bitrate as a useful example. It will also match native API more closely.

Thoughts?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.