feross / feross/simple-peer

Remove distinction between offer/answer constraints in constructor

Open
#531 4 comments 0 reactions 0 assignees View on GitHub
feature request
Dominant language
JavaScript
Stars
7.8k
Forks
983
PR merge metrics
No merged PRs in 30d

Description

This issue was raised in a comment by @nazar-pc and didn't want it to get lost:

> I have a generic concern about constraints separation. Second argument `constraints` in `RTCPeerConnection` was removed from the spec a long time ago. At the same time answer/offer constraints are obvious from the context.
>
> I'd like to see a single `peer.setConstraints()` method that under the hood resolves to either `offerConstraints` or `answerConstraints` and do not even expose this separation for the user. In future major version I'd remove this separation entirely in constructor options too.

_Originally posted by @nazar-pc in https://github.com/feross/simple-peer/pull/324#issuecomment-396762783_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.