feross / feross/simple-get

information about timeout

Open
#87 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
402
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Hi,

It says in the README "You can set a timeout (in milliseconds)".

However it doesn't explain the default. What if timeout has not been manually set? What is the "default" behavior? Will it "never" timeout? That is, hang indefinitely? Or is there a built-in value.

Next, I have found a codebase where they appear to have manually set timeout to 0. What is the meaning of that? Does it mean "never" timeout, and so wait indefinitely? However, this particular program will quickly says "Request timed out" so it contradicts this idea.

Would you consider adding information about both of these timeout cases (the "default", as well as "0") in the README?

----

Edit: There was a version mismatch between the code I was examining, and the module that was installed. So what I said above, about the program quickly timed out... that was not certainly with "0" configured.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.