feross / feross/safe-buffer

Update README to reflect current state of `Buffer` in Node?

Open
#38 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
345
Forks
47
PR merge metrics
No merged PRs in 30d

Description

If I understand correctly, the vulnerability / trap / questionable design choice that this package exists to address was fixed in Node itself in 2017? At least, the [`new Buffer(size)`](https://nodejs.org/api/buffer.html#new-buffersize) docs say that since version 8.0.0 of Node:

> The `new Buffer(size)` will return zero-filled memory by default.

Yet `safe-buffer`'s README [still says](https://github.com/feross/safe-buffer?tab=readme-ov-file#why-is-buffer-unsafe) that `Buffer` "is" unsafe "today". This is basically untrue, no?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.