feross / feross/safe-buffer

safe-buffer in modern build tools like Vitejs

Open
#30 10 comments 8 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
345
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Hey, i'm trying to use ViteJs for project.

Since this is es6 only, the code errors out inside safe-buffer package `Buffer` is undefined here

Screenshot 2021-04-19 at 11 31 26

If we included this simple check, this wouldn't error out in ViteJs environment.
Screenshot 2021-04-19 at 11 32 12

Is there any reason not to include check like this? If you would be interested, i could submit PR

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.