feross / feross/p2p-graph

Don't remove `Element` on `destroy()`

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
285
Forks
31
PR merge metrics
No merged PRs in 30d

Description

https://github.com/feross/p2p-graph/blob/3334451e147e77778200412f553f2cd1277a2750/index.js#L261

When calling `destroy()`, the `Element` where the graph is being applied is removed from the DOM. Since this element is not created and managed by `p2p-graph` but instead provided by us, it should be left untouched, as it's done at https://github.com/Novage/p2p-media-loader/blob/85adce9b0edbc00dfa073321d93a61590af3afc8/p2p-media-loader-demo/index.html#L1234-L1240

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.