feross / feross/is-buffer

Adding `sideEffects: false` to package.json

Open
#45 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
94
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Hello! :)

Would it make sense to add `sideEffects: false` to this library's `package.json`? This can enable more tree-shaking, in some cases: [documentation](https://github.com/webpack/webpack/blob/main/examples/side-effects/README.md) ([more detailed documentation](https://github.com/webpack/webpack.js.org/blob/6bc07960d30b7c534d809de86f1d611e9973af37/src/content/guides/tree-shaking.mdx))

If so, I'd be happy to open a PR :)

(Note: I think this library would need to first by upgraded to ESM)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.