ferd / ferd/cth_readable

Incorrect group names when groups running in parallel

Open
#30 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Erlang
Stars
49
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Given the following suite `foo_SUITE`:

```erl
-module(foo_SUITE).

-export([
suite/0,
all/0,
groups/0,
init_per_suite/1,
end_per_suite/1,
init_per_group/2,
end_per_group/2,
init_per_testcase/2,
end_per_testcase/2
]).

-export([a/1, b/1, c/1]).

suite() ->
[{timetrap, {seconds, 10}}].

init_per_suite(Config) ->
Config.

end_per_suite(_Config) ->
ok.

init_per_group(_GroupName, Config) ->
Config.

end_per_group(_GroupName, _Config) ->
ok.

init_per_testcase(_TestCase, Config) ->
Config.

end_per_testcase(_TestCase, _Config) ->
ok.

groups() ->
[
{as, [parallel], [
a,
{group, bs}
]},
{bs, [parallel], [
b
]},
{all, [parallel], [
{group, as},
c
]}
].

all() ->
[
{group, all}
].

a(_) -> timer:sleep(1000), error(a).

b(_) -> timer:sleep(1000), error(b).

c(_) -> timer:sleep(1000), error(c).
```

Running the default `rebar3 ct` produces:
```
%%% foo_SUITE:
%%% foo_SUITE ==> all.as.bs.a: FAILED
%%% foo_SUITE ==> {a,[{foo_SUITE,a,1,
[{file,"/data/users/micmus/github/erlfmt/test/foo_SUITE.erl"},
{line,58}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
{test_server,run_test_case_eval1,6,[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}

%%% foo_SUITE ==> all.as.bs.b: FAILED
%%% foo_SUITE ==> {b,[{foo_SUITE,b,1,
[{file,"/data/users/micmus/github/erlfmt/test/foo_SUITE.erl"},
{line,60}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
{test_server,run_test_case_eval1,6,[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}

%%% foo_SUITE ==> all.c: FAILED
%%% foo_SUITE ==> {c,[{foo_SUITE,c,1,
[{file,"/data/users/micmus/github/erlfmt/test/foo_SUITE.erl"},
{line,62}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1748}]},
{test_server,run_test_case_eval1,6,[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}
```

Note the incorrecy name `all.as.bs.a` - test `a` does not belong to `bs` group.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.