felixse / felixse/FluentTerminal

Copy multiline text may fail for some lines

Open
#169 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C#
Stars
9.6k
Forks
448
PR merge metrics
No merged PRs in 30d

Description

Hello.

Context: Wsl / ssh to remote linux and tailed some logs

When the displayed line in the terminal ends with a conventional character the copy works well.
But, if the line ends with a space character then the log line is splitted.
Check the red square on the next picture and compare with the result pasted in vscode.

![image](https://user-images.githubusercontent.com/11785076/50863063-c5276f80-139d-11e9-957d-96ee0a65c08a.png)

As we can see with the previous log line, if the displayed line starts with a space, the complete log line is kept.

I noticed they handled it in vscode's terminal which is also using xterm.

Could it be possible the simple use of their version of xterm would solve the issue?
https://github.com/Microsoft/vscode/blob/1.30.2/package.json
https://www.npmjs.com/package/vscode-xterm

In the meantime I wonder if vscode-xterm is not too far from xterm, because I did cross read this post https://codeburst.io/source-reading-how-is-new-terminal-in-vs-code-so-fast-10a40f7f8792.

Aside that, nice work! Looks promising 👍

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.