felixrieseberg / felixrieseberg/responsive-images-generator

default require() is not working

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
55
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Hi,

I gave that module a try and there is a little bug which I want to mention:

### require() does not work like expected

Instead of:
``` js
const generateResponsiveImages = require('responsive-images-generator').generateResponsiveImages;
```
I have to do that:

``` js
const generateResponsiveImages = require('responsive-images-generator/lib').generateResponsiveImages;
```
In order to fix that, a little update of the main entry in your `package.json` should be enough.

### Enhancement

Would be great to get all data objects back (like an image object with path and configs) in promise handling:

``` js
generateResponsiveImages(images, configs)
.then(data => handleDataObjects(data));
```

For now I only get back an array with `undefined` items in it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.