felixge / felixge/node-stream-cache

write after end

Open
#6 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
44
Forks
12
PR merge metrics
No merged PRs in 30d

Description

I took a quick look at the implementation and it looks like all `Stream#write()` calls are used as if they were synchronous, but [they are not](https://nodejs.org/dist/latest-v8.x/docs/api/stream.html#stream_writable_write_chunk_encoding_callback).

The result is that we close the stream before all writes are done.

Am I correct? Or there is something that I am missing?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.