felixge / felixge/node-growing-file

_ended is never set to true

Open
#4 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
106
Forks
14
PR merge metrics
No merged PRs in 30d

Description

Hi. I've just been reading `lib/growing_file.js` and I noticed that _end is tested...

``` javascript
GrowingFile.prototype._reachedEnd = function() {
return (this._ended || this._timedOut());
};
```

but there's no code that sets _end to true. It's always false. Is it a bug?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.