fedora-python / fedora-python/python-rpm-porting

Shebangs with spaces are not corrected by our sed

Open
#26 0 comments 0 reactions 1 assignee Claimed by @torsava View on GitHub
Dominant language
Python
Stars
4
Forks
4
PR merge metrics
No merged PRs in 30d

Description

See:

https://src.fedoraproject.org/rpms/chromium/pull-request/11

chromium used a copy pasted sed from our guide. yet it was wrong.

The problematic shebang was (something like):

#! /usr/bin/env python

Notice the space.

BTW Instead of fixing the shebang in the guide and making it even more complicated, we can recommend pathfix.py as described in https://github.com/fedora-python/python-rpm-porting/issues/24

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.