feathr-ai / feathr-ai/feathr

Samples should use a single credential

Open
#547 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Scala
Stars
1.9k
Forks
247
PR merge metrics
No merged PRs in 30d

Description

In all the Jupyter notebook samples, there's a line:

client = FeathrClient(config_path=tmp.name)

However, if the users have configured credential in the previous line, like this:

credential = DefaultAzureCredential(exclude_interactive_browser_credential=False)

this `credential` variable isn't passed to `FeathrClient`, which causes trouble because FeathrClient will initialize a credential again which might be different.

We should change all the lines to below to use the same credential across the sample notebook.

client = FeathrClient(config_path=tmp.name, credential=credential)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.