feast-dev / feast-dev/feast

Update great-expectations to latest (>1)

Open
#5,087 9 comments 0 reactions 0 assignees View on GitHub
good first issue kind/bug priority/p2
Dominant language
Python
Stars
7.3k
Forks
1.4k
Avg merge
1d 21h
Merged PRs (30d)
15

Description

## Expected Behavior

great-expectations version updated to latest (>1).

https://github.com/feast-dev/feast/blob/master/pyproject.toml#L73

## Current Behavior

The `great_expectations.dataset` module, which included classes like` PandasDataset`, has been deprecated in recent versions of Great Expectations and was fully removed in version 1.0. This change means that attempting to import from great_expectations.dataset will result in a `ModuleNotFoundError`

https://github.com/feast-dev/feast/blob/master/sdk/python/tests/integration/offline_store/test_dqm_validation.py#L8

## Steps to reproduce

Update great-expectations to latest and run `sdk/python/tests/integration/offline_store/test_dqm_validation.py`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.