fb55 / fb55/readabilitySAX

Article images need better detection

Open
#29 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

awaiting-implementation
Dominant language
TypeScript
Stars
249
Forks
35
Avg merge
1d 7h
Merged PRs (30d)
1

Description

There are a few times where Safari Reader is doing a better job of leaving in article images that are filtered out by readabilitySAX. Here is an example: http://hommemaker.com/2012/08/20/why-the-gays-hate-their-bodies/. Compare the Safari Reader rendering with readabilitySAX. In this case readabilitySAX should preserve images that are wrapped inside a a parent and p grandparent tag. The general rule might be that if there is a single image of sufficient size with any number of wrapping tags these images are candidates. There is probably a better general rule, that is just my take on it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the Safari Reader rendering with readabilitySAX for the linked article, then trace the image-filtering behavior in the project. The issue specifically proposes preserving a sufficiently large image wrapped by an a parent and p grandparent, but the general rule and completion criteria remain undecided.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
content
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.