fastruby / fastruby/skunk.fyi

[BUG] Exit status is not 0 when the skunk score improved

Open
#104 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
7
Forks
1
Avg merge
1h 30m
Merged PRs (30d)
1

Description

**Branch/Commit:**

Version 0.5.2.

**Expected behavior:**

When comparing 2 branches, if the new branch has a better skunk score above the threshold, the exit status of the command should be 0 so it's not considered a failure.

**Actual behavior:**

When the score improves above the threshold, the exit status is non-zero so it's considered a failure in CI.

From this PR https://github.com/fastruby/skunk.fyi/actions/runs/6655872886/job/18087134376?pr=103

![image](https://github.com/fastruby/skunk.fyi/assets/188464/49587d01-092c-482e-aa59-5010fbddefd1)

**Steps to reproduce:**

Run the compare command for a new PR improving the skunk score average by more than the threshold.

**I will abide by the [code of conduct](https://github.com/fastruby/skunk.fyi/blob/main/CODE_OF_CONDUCT.md)**

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.