fastruby / fastruby/rubocop-ombu_labs

Gem reporting false positives

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Ruby
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Hi there,

I'm trying to commit a few changes but I'm running into a false positive:

```
git commit app config public spec
Errors on modified lines:
/Users/etagwerker/Projects/ombulabs/fastruby.io/app/mailers/contact_mailer.rb:6:14: C: OmbuLabs/Branding: Wrong branding, use "OmbuLabs"
/Users/etagwerker/Projects/ombulabs/fastruby.io/app/mailers/roadmap_mailer.rb:5:20: C: OmbuLabs/Branding: Wrong branding, use "OmbuLabs"
✗ One or more pre-commit hooks failed
```

When I check the files I see that the branding is accurately defined in the lines that are reported:

```
$ cat app/mailers/contact_mailer.rb
class ContactMailer < ApplicationMailer
# Delivers an email to ops@ombulabs.com
def contact_email(contact)
@contact = contact
mail(subject: "[Rails Upgrade] #{contact.name} just sent you a message",
to: "ops@OmbuLabs.com",
reply_to: contact.email)
end
end
$ cat app/mailers/roadmap_mailer.rb
class RoadmapMailer < ApplicationMailer
def roadmap_email(user_email)
mail(subject: "We received your registration!",
to: user_email,
reply_to: "ops@OmbuLabs.com")
end
end
```

Maybe it is mis-interpreting the brand name when it is used within a domain?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.