fastruby / fastruby/ombu_labs-notifications

[BUG] Log messages are inaccurate: "Sent email to ernesto@example.com"

Open
#6 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Hi there,

Small issue. When I submit an email through the ContactMailerWorker, I see this in the logs:

```
2023-11-21T19:45:23.688412+00:00 app[worker.1]: I, [2023-11-21T19:45:23.688364 #2] INFO -- : Delivered mail 655d08d35b1d0_2143e8657e1@220dcdf7-d7e4-4ad8-9324-a173302847ea.mail (315.3ms)
2023-11-21T19:45:23.690711+00:00 app[worker.1]: 2 TID-1rze ContactMailerWorker JID-9142c0e6ed4e92158824f3fe INFO: Sent email to ernesto@example.com
2023-11-21T19:45:23.690779+00:00 app[worker.1]: 2 TID-1rze ContactMailerWorker JID-9142c0e6ed4e92158824f3fe INFO: done: 0.404 sec
```

## Expected

I'd expect the log to display the right email address: https://github.com/fastruby/ombu_labs-notifications/blob/main/app/mailers/contact_mailer.rb#L7-L9

## Current

It is now saying that it sent an email to `contact.email` but that field is only used in the reply-to attribute.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.