fastify / fastify/help

createSecretKey and hmac (e.g. in fastify/cookie)

Open
#968 3 comments 1 reaction 0 assignees View on GitHub
help wanted
Dominant language
No language data
Stars
68
Forks
8
Avg merge
11h 2m
Merged PRs (30d)
2

Description

I wanted to have an open discussion regarding the use of secret keys in hmac.

I think we can have performance improvements by using createSecretKey. Atleast it seems that the heap usage could be reduced.

We should consider investigating this?!

I am opening this issue to not forget about it. It is 2 o clock in the morning and I saw this potential perf improvement while checking the performance of a different product. Good night.

@kibertoad
@Fdawgs
@Eomm
@gurgunday
@mcollina

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.