fastify / fastify/fastify-vite

Not very many lint rules are turned on

Open
#336 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.1k
Forks
103
Avg merge
6h 54m
Merged PRs (30d)
7

Description

`oxlint` was integrated in #328, but I could barely turn on any lint rules. This repo hasn't had linting in CI since probably the beginning, so there are lint violations to most rules everywhere.

I only turned on the [correctness category](https://oxc.rs/docs/guide/usage/linter/rules.html#correctness-201) of rules, and even then I had to disable the [no-unused-vars rule](https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-unused-vars.html). There are unused vars all over the place.

I think we should aim for a stricter lint rule set, perhaps something close to https://standardjs.com/. However, standard still uses ESLint. I could try and replicate most of it in the oxlint configuration, but my guess is that this repo will have many many violations to fix.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.