fastify / fastify/fastify-error

Strict amount of parameters, change input to array or object

Open
#117 3 comments 4 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
JavaScript
Stars
135
Forks
23
PR merge metrics
No merged PRs in 30d

Description

### Prerequisites

- [X] I have written a descriptive issue title
- [X] I have searched existing issues to ensure the issue has not already been raised

### Issue

Maybe it makes sense to have a strict amount of parameters. So when the format string is '"%s is not a valid %s", then we need to provide exact two parameters. If you provide zero, one or more than two parameters, we have an issue. Like nodejs errors are done. This would result in the ability to say, that the last parameter is e.g. used for "cause" or other options.

Now the implementation of #116 is kind of messy. But not because of the contributor but because our code is not good enough.

This would be a semver-major.

Also we could then use #103 and avoid the use of util format, making it platform independent. Maybe also usable in browser.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.