farhadi / farhadi/rate_limiter

No ETS cleanup?

Open
#19 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Elixir
Stars
36
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Hi folks,

thanks a lot for the project!

In micro benchmarks the performance is truly impressive compared to other solutions.

Looking through the code, I don't think there is any cleanup of the ETS table used to store the rate limiters - am I missing something? Ideally, I think the ETS should be cleaned up - depending on what you rate limit on you might not hear from a client in a long time and so that would just get up memory consumption it feels like.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.