farhadi / farhadi/node-smpp

COctet String : max length

Open
#216 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
435
Forks
194
PR merge metrics
No merged PRs in 30d

Description

Hi @farhadi and maintainers,
Unless I am wrong the lib is not considering the field size as per SMPP specification.
For example, "bind_transmitter.password" is "C-Octet String" with max length = 9. Am I correct ?
If so, is it intentional or maybe planned in future release ?
I noticed that all types are statically defined in "defs.types".
What would be the best way to implement such evolution ?
Thanks a lot for your support

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.