faressoft / faressoft/terminalizer

Terminalizer exits straight after starting recording.

Open
#78 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.2k
Forks
520
PR merge metrics
No merged PRs in 30d

Description

Below happens when starting recording, rapidly goes through started>finished>share without recording anything.

Node version : v12.13.1

``` terminal
user@ThinkPad:~/termin$ node node_modules/terminalizer/app.js record demo
The recording session is started
Press CTRL+D to exit and save the recording
Successfully Recorded
The recording data is saved into the file:
/home/user/termin/demo.yml
You can edit the file and even change the configurations.

Let's now share your recording on https://terminalizer.com
The command `terminalizer share`can be used anytime to share recordings!

Please enter some details about your recording
? Title demo
? Description demo
? Tags such as git,bash,game demo

/home/user/termin/node_modules/terminalizer/commands/share.js:199
return reject(body.errors.join('\n'));
^

TypeError: Cannot read property 'join' of undefined
at Request._callback (/home/user/termin/node_modules/terminalizer/commands/share.js:199:35)
at Request.self.callback (/home/user/termin/node_modules/request/request.js:185:22)
at Request.emit (events.js:210:5)
at Request. (/home/user/termin/node_modules/request/request.js:1161:10)
at Request.emit (events.js:210:5)
at IncomingMessage. (/home/user/termin/node_modules/request/request.js:1083:12)
at Object.onceWrapper (events.js:299:28)
at IncomingMessage.emit (events.js:215:7)
at endReadableNT (_stream_readable.js:1184:12)
at processTicksAndRejections (internal/process/task_queues.js:80:21)
user@ThinkPad:~/termin$ node node_modules/terminalizer/app.js play demo
user@ThinkPad:~/termin$ node node_modules/terminalizer/app.js play demo
user@ThinkPad:~/termin$

```

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce `node node_modules/terminalizer/app.js record demo` with Node v12.13.1, then inspect `node_modules/terminalizer/commands/share.js` at line 199 and the record/play entry points in `app.js`. Done means recording does not immediately finish, `play demo` produces the saved recording, and sharing no longer raises the reported `TypeError`.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.