faressoft / faressoft/terminalizer

No token & errors in generating share

Open
#49 2 comments 7 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
16.2k
Forks
520
PR merge metrics
No merged PRs in 30d

Description

~$ terminalizer share test
Please enter some details about your recording
? Title Test
? Description Testing terminalizer
? Tags such as git,bash,game linux

/usr/local/lib/node_modules/terminalizer/commands/share.js:194
return reject(body.errors.join('\n'));
^

TypeError: Cannot read property 'join' of undefined
at Request._callback (/usr/local/lib/node_modules/terminalizer/commands/share.js:194:35)
at Request.self.callback (/usr/local/lib/node_modules/terminalizer/node_modules/request/request.js:185:22)
at emitTwo (events.js:126:13)
at Request.emit (events.js:214:7)
at Request. (/usr/local/lib/node_modules/terminalizer/node_modules/request/request.js:1161:10)
at emitOne (events.js:116:13)
at Request.emit (events.js:211:7)
at IncomingMessage. (/usr/local/lib/node_modules/terminalizer/node_modules/request/request.js:1083:12)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:111:20)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the failure with `terminalizer share test`, then inspect `commands/share.js` around line 194 and the response handling used by the share request. Trace the response shape when no token or errors are returned, and consider the issue done when this case reports an actionable error instead of throwing on `body.errors.join`. Run the relevant share command checks available in the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.