faressoft / faressoft/onesignal

It doesn't reject on error

Open
#2 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20
Forks
7
PR merge metrics
No merged PRs in 30d

Description

I hate the following result:

```
{
errors: ['Identifier invalid format.']
}
```

This does not seem to reject the Promise but silently fails with an undefined value in the callback (since `.id` is undefined).

This is on the addDevice function

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.