faceyspacey / faceyspacey/react-universal-component
wrong naming convention used for error and isLoading props
- Dominant language
- JavaScript
- Stars
- 1.7k
- Forks
- 80
- PR merge metrics
- No merged PRs in 30d
Description
while using the universal component if a developer pass an error props for its own handling of error in the component, then what happens is that in the npm itself we are using the error props and based on that props we are returning the error component.
error and isLoading is very common name we should rename those two props.
for e.g
import ShowData from '../ShowData/ShowData.async'
const MyComponent = ({error,data})=>{
return < ShowData error={error} data={data} />
}
>>>>ShowData.async.js>>>>>>>>.
const ShowData = universal(
import('./ShowData'),
);
export default ShowData;
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.