faceyspacey / faceyspacey/react-universal-component

react-redux 6.0.0

Open
#172 12 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.7k
Forks
80
PR merge metrics
No merged PRs in 30d

Description

Just ran into an issue with the new way react-redux behaves.
You can see more details about it in this thread: https://github.com/reduxjs/react-redux/issues/935#issuecomment-446515270

As we can see from the last release of react-redux 6.0.0: https://github.com/reduxjs/react-redux/releases
```
Behavior Changes
Any library that attempts to access the store instance out of legacy context will break, because we now put the store state into a instead. Examples of this include connected-react-router and react-redux-subspace. (The current implementation does also put the store itself into that same context. While accessing the store in context is not part of our public API, we will still try to make it possible for other libraries to access it, with the understanding that this could break at any time.)
```

This makes the `onLoad` function not working properly. The fourth parameter `context` is no more populated with the store.
Although it is not a real issue for me, as I use `redux-reducers-injector` (I'm the maintainer), I have a reference of the store that I can use, and can use `replaceReducer`.
The real issue is that even with injecting my reducer correctly, the `mapStateToProps` will not reflect this change in its first parameter `state` and I won't be able to display my component correctly.

You can read more about this issue in the link I post above on the react-redux project: https://github.com/reduxjs/react-redux/issues/935#issuecomment-446515270

Feel free to ask me more information about this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.