faceyspacey / faceyspacey/babel-plugin-universal-import

Typescript and non-Babel environments example out of sync with TypeScript definitions

Open
#31 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
114
Forks
38
PR merge metrics
No merged PRs in 30d

Description

The `universal` options in the [example](https://github.com/faceyspacey/babel-plugin-universal-import#typescript-and-non-babel-environments) (`chunkName` and `resolve`) don't exist in the current [react-universal-component declaration file](https://github.com/faceyspacey/react-universal-component/blob/master/index.d.ts). Interestingly, the [Flow types](https://github.com/faceyspacey/react-universal-component/blob/master/src/flowTypes.js#L43-L61) contain the properties, though.

Can this example be updated with the appropriate options that should be passed when used in a TypeScript project or can the TypeScript definitions for react-universal-component be updated to reflect the valid options?

/cc @forabi @Alex-Krautmann

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.