facebookresearch / facebookresearch/tribev2

Bug: pyproject.toml lists 'pip' as runtime dependency and hard-pins numpy version

Open Beginner friendly
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
3.2k
Forks
696
PR merge metrics
No merged PRs in 30d

Description

Bug Description

pyproject.toml has two packaging issues in the dependencies list:

1. pip listed as a runtime dependency
"pip",

pip is a package manager, not a library. Listing it as a runtime dependency has no effect and is incorrect. It should be removed.

2. numpy hard-pinned with ==
"numpy==2.2.6",

Hard-pinning with == in a library's pyproject.toml forces all users and downstream environments to use exactly that patch version. This causes installation conflicts for anyone who has a different NumPy version installed.

Fix

# Remove pip entirely
# Change numpy pin to a range:
"numpy>=2.0,<3",

Impact

Anyone trying to install tribev2 alongside other packages that require a different NumPy version will hit a dependency conflict immediately.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open pyproject.toml and inspect the dependencies list. Remove pip and replace the exact numpy pin with the specified >=2.0,<3 range; done means the dependency entries match the issue's requested metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
numpy, python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.