facebookresearch / facebookresearch/theseus
Simplify _optimize_loop method
Open
good first issue
refactor
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Description
how about
```
if backward_mode == BackwardMode.IMPLICIT or backward_mode == BackwardMode.TRUNCATED
```
so we have less redundant variables?
_Originally posted by @mhmukadam in https://github.com/facebookresearch/theseus/pull/81#discussion_r810434614_
Contributor guide
Research direction
Search the repository for the _optimize_loop method and the BackwardMode checks mentioned in the issue. Compare the current redundant-variable logic with the proposed condition, then run the relevant existing tests and confirm optimization behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100