facebookresearch / facebookresearch/theseus

Refactor SE2 and SE3 to use rotation-then-translation format

Open
#76 0 comments 0 reactions 1 assignee Claimed by @fantaosha View on GitHub
Dominant language
Python
Stars
2.1k
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Sophus uses rotation-then-translation everywhere, gtsam is the same except for SE2 where it is flipped.

We should consider refactoring SE2 in that case, unless there are any consequences (and why gtsam uses the flipped convention for it). Aside from the function signature, the data order would also likely change then (x, y, c, s -> c, s, x, y).

_Originally posted by @mhmukadam in https://github.com/facebookresearch/theseus/pull/68#discussion_r801450549_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.