facebookresearch / facebookresearch/theseus

Sparse solver class and autograd consolidation

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactor
Dominant language
Python
Stars
2.1k
Forks
149
PR merge metrics
No merged PRs in 30d

Description

- From discussion [here](https://github.com/facebookresearch/theseus/pull/24#discussion_r773375323): common code between autograd functions of different sparse solvers can be consolidated.
- Add an intermediate sparse solver class, see comment [here](https://github.com/facebookresearch/theseus/pull/24#discussion_r773958356) and make implementation consistent with dense solver.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the two linked discussion comments in pull request #24, then compare the sparse solver autograd implementations with the dense solver implementation. Done means common sparse autograd code is consolidated and an intermediate sparse solver class is added with behavior consistent with the dense solver.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.