facebookresearch / facebookresearch/stopes
Minor bug in ALTI's code
Open
- Dominant language
- Python
- Stars
- 313
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
We've recently found a minor bug in ALTI's code. It's in this line:
https://github.com/facebookresearch/stopes/blob/0c6535afd7eff3154883c5301d0dd518496760ee/stopes/eval/alti/wrappers/transformer_wrapper.py#L474
The parameter `unbiased` from `torch.std` should be set to `False`, since the default is `True`. The expected behavior of this is without the Bessel's correction.
Relevant discussion related with this: https://github.com/pytorch/pytorch/issues/50010
Contributor guide
Assessment
This issue has not been assessed yet.