facebookresearch / facebookresearch/sam3

`x.dim` should be `x.dim()`

Open
#355 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
11.7k
Forks
1.8k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/facebookresearch/sam3/blob/b26a5f330e05d321afb39d01d3d4881f258f65ff/sam3/model/encoder.py#L540

Since `x.dim` is a method and not a property. The comparison `x.dim == 4` evaluates to `False`. This path is hit if `feat_sizes` is not provided to `TransformerEncoderFusion`.

Contributor guide

Open the contributing guide

Research direction

Open sam3/model/encoder.py at line 540 and inspect the path used when feat_sizes is not provided to TransformerEncoderFusion. Confirm that the dimension check invokes the method, then verify that this path correctly handles four-dimensional inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision, machine-learning
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.