facebookresearch / facebookresearch/pytorch3d

pytorch3d 0.7.4 still leaks a `projects` module via pip install

Open
#1,602 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
10k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

## 🐛 Bugs / Unexpected behaviors

Related to https://github.com/facebookresearch/pytorch3d/issues/1279.

The situation is slightly better now, but the package still leaks a `projects/__init__.py` file which would still cause clashes since our repo also has a top-level `projects` dir. Previously it had more files.

## Instructions To Reproduce the Issue:

Please include the following (depending on what the issue is):

1. The exact command(s) you ran:
I was using a base conda environment that had torch, and the venv was created with `--system-site-packages` so I didn't have to install `torch` into the venv.
```
(venv) (base)
[10:36:12 | last: 0s] ( 0) | ~
igozali@hostname $ pip install --force --no-deps "git+https://github.com/facebookresearch/pytorch3d.git@v0.7.4"

(venv) (base)
[10:38:00 | last: 0s] ( 0) | ~/venv/lib/python3.8/site-packages
igozali@hostname $ ls
_distutils_hack distutils-precedence.pth pip pip-22.0.4.dist-info pkg_resources projects pytorch3d pytorch3d-0.7.4.dist-info setuptools setuptools-56.0.0.dist-info

(venv) (base)
[10:38:00 | last: 0s] ( 0) | ~/venv/lib/python3.8/site-packages
igozali@hostname $ ls projects
__init__.py __pycache__

(venv) (base)
[10:38:07 | last: 0s] ( 0) | ~/venv/lib/python3.8/site-packages
igozali@hostname $ cat projects/__init__.py
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
```

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported pip install command for pytorch3d v0.7.4 and inspect the installed site-packages contents, especially projects/__init__.py. Trace which packaging entry point includes that file; done means installing the package no longer creates the conflicting top-level projects module.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.