facebookresearch / facebookresearch/faiss

`bruteForceKnn` uses 64-bit int for output indices but limits the number of vectors to int.

Open
#976 1 comment 0 reactions 1 assignee Claimed by @wickedfoo View on GitHub
enhancement GPU
Dominant language
C++
Stars
40.9k
Forks
4.5k
PR merge metrics
No merged PRs in 30d

Description

# Summary

`idx_t` type is typedef'd to an `int64_t` the output index array from `bruteForceKnn` requires an `idx_t` type. This should allow an extremely large number of input vectors to query, however, the `numVectors` argument is only an int. If the `numVectors` argument were changed to `idx_t` type, it would allow us to scale beyond the number of elements that an integer can represent.

Running on:
- [ ] CPU
- [X] GPU

Interface:
- [X] C++
- [ ] Python

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.