facebookresearch / facebookresearch/faiss

range_search doesn't support a radius vector

Open
#2,157 2 comments 0 reactions 0 assignees View on GitHub
feature request Implementation
Dominant language
C++
Stars
40.9k
Forks
4.5k
PR merge metrics
No merged PRs in 30d

Description

It caught my attention that range_search doesn't support a vector of radius values as an input, such that each value correspond to the radius to query each row. Would this be faster than query_radius from sklearn's KDTree? If not, is this the reason this is not implemented?

This could be a very good feature since it is the last thing needed for a faster (and accurate) calculation of Kraskov's mutual information.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the existing range_search API and its handling of query rows. Define how a radius vector maps to those rows, then compare the behavior and performance with sklearn's KDTree query_radius as raised in the issue. Done means the API supports per-row radii with accurate results and has coverage for the new behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
search
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.