facebookresearch / facebookresearch/fairseq2

fairseq2 breaks / will break with PyTorch nightlies

Open
#1,453 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1.1k
Forks
144
Avg merge
4d 1h
Merged PRs (30d)
1

Description

The `torch.cc` file copies the definition of THPVariable which has changed. It's now just `at::Tensor cdata` instead of `at::MaybeOwned cdata`.

https://github.com/facebookresearch/fairseq2/blob/fb2a3f35d783c21697ca75050743112ab5559e73/native/python/src/fairseq2n/bindings/type_casters/torch.cc#L18-L21

https://github.com/pytorch/pytorch/blob/84a7a34e5fb22c89530791136dc5f3023d2f709b/torch/csrc/autograd/python_variable.h#L17-L28

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.