facebookresearch / facebookresearch/fairo

Investigate why test_cuberite_agent_connection is failing on #773

Open
#811 0 comments 0 reactions 2 assignees Claimed by @kavyasrinet View on GitHub
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [x] Bug report (to report a bug)
- [ ] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description

The MC unittest `test_cuberite_agent_connection` is failing after #773 is merged. Investigate this issue and bring this unittest back once figure it out (#810 ). The problems here are:

1. the changes of #773 seems totally irrelevant to this unittest
2. the unittest usually fails but also can pass transiently
3. reran CI with ssh and sshed into CI env to the same command, I obvserved the unittest is actually passing.

## Steps to reproduce

Please add steps to reproduce the bug here along with the stack trace.

## Links to any relevant pastes or documents

Please post links to any relevant documents that might contain any extra information.

## Checklist

Use this checklist if you are using this issue as a tracker:

- [ ] Task 1
- [ ] Task 2
- [ ] Task 3 ...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.