facebookresearch / facebookresearch/fairo

Extra spaces are appended to words

Open
#764 0 comments 0 reactions 2 assignees Claimed by @ethan-carlson View on GitHub
Dominant language
Jupyter Notebook
Stars
929
Forks
123
PR merge metrics
No merged PRs in 30d

Description

## Type of Issue

Select the type of issue:
- [X] Bug report (to report a bug)
- [ ] Feature request (to request an additional feature)
- [ ] Tracker (I am just using this as a tracker)
- [ ] Refactor request
- [ ] Documentation Ask

## Description

When there are extra spaces in commands issued to the craftassist agent through the dashboard, these get appended onto neighboring words as   characters. The NSP seems to handle this OK, but it circumvents other systems eg. ground truth matching.

## Steps to reproduce

Issue a command to the craftassist agent through the dashbaord with extra or trailing spaces, eg. "dig a hole "

## Links to any relevant pastes or documents

**Without extra spaces**
> INFO:root:Incoming chats: [' dig a hole']
> 2021-10-27 16:11:19,588 [nsp_querier.py:81 - perceive() INFO]: Incoming chats: [' dig a hole']
> INFO:root:Found ground truth action for "dig a hole"
> 2021-10-27 16:11:19,589 [nsp_querier.py:187 - get_logical_form() INFO]: Found ground truth action for "dig a hole"
> INFO:root:logical form post co-ref and process_spans "25610cb5104635270396e2caa05341889220c97847d845c6bdf4e0a90efe316f:bc037325e9a44d129d96e8bc9a2b56a7" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole'}]}}}, 'action_type': 'DIG'}]}
> 2021-10-27 16:11:19,619 [map_to_dialogue_object.py:114 - postprocess_logical_form() INFO]: logical form post co-ref and process_spans "25610cb5104635270396e2caa05341889220c97847d845c6bdf4e0a90efe316f:bc037325e9a44d129d96e8bc9a2b56a7" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole'}]}}}, 'action_type': 'DIG'}]}
> INFO:root:update_recent_entities []
> 2021-10-27 16:11:19,620 [sql_memory.py:227 - update_recent_entities() INFO]: update_recent_entities []
> INFO:root:Sending chat: I finished digging this.
> 2021-10-27 16:11:21,493 [craftassist_agent.py:347 - send_chat() INFO]: Sending chat: I finished digging this.

**With a trailing space**
> INFO:root:Incoming chats: [' dig a hole ']
> 2021-10-27 16:11:33,670 [nsp_querier.py:81 - perceive() INFO]: Incoming chats: [' dig a hole ']
> INFO:root:Querying the semantic parsing model
> 2021-10-27 16:11:33,671 [nsp_model_wrapper.py:65 - query_for_logical_form() INFO]: Querying the semantic parsing model
> INFO:root:logical form post co-ref and process_spans "c9d07ee04c58a2f1a02079ce81d3e90ac402efb72e0f251176de09f1f08223be:db3dae53eaf14f4e8b8c2b17f90a6991" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DIG', 'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole '}]}}, 'text_span': 'hole '}}]}
> 2021-10-27 16:11:40,955 [map_to_dialogue_object.py:114 - postprocess_logical_form() INFO]: logical form post co-ref and process_spans "c9d07ee04c58a2f1a02079ce81d3e90ac402efb72e0f251176de09f1f08223be:db3dae53eaf14f4e8b8c2b17f90a6991" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DIG', 'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole '}]}}, 'text_span': 'hole '}}]}
> INFO:root:update_recent_entities []
> 2021-10-27 16:11:40,956 [sql_memory.py:227 - update_recent_entities() INFO]: update_recent_entities []
> INFO:root:Sending chat: I finished digging this.
> 2021-10-27 16:11:41,029 [craftassist_agent.py:347 - send_chat() INFO]: Sending chat: I finished digging this.

**With extra spaces**
> INFO:root:Incoming chats: [' dig a hole ']
> 2021-10-27 16:11:33,670 [nsp_querier.py:81 - perceive() INFO]: Incoming chats: [' dig a hole ']
> INFO:root:Querying the semantic parsing model
> 2021-10-27 16:11:33,671 [nsp_model_wrapper.py:65 - query_for_logical_form() INFO]: Querying the semantic parsing model
> INFO:root:logical form post co-ref and process_spans "c9d07ee04c58a2f1a02079ce81d3e90ac402efb72e0f251176de09f1f08223be:db3dae53eaf14f4e8b8c2b17f90a6991" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DIG', 'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole '}]}}, 'text_span': 'hole '}}]}
> 2021-10-27 16:11:40,955 [map_to_dialogue_object.py:114 - postprocess_logical_form() INFO]: logical form post co-ref and process_spans "c9d07ee04c58a2f1a02079ce81d3e90ac402efb72e0f251176de09f1f08223be:db3dae53eaf14f4e8b8c2b17f90a6991" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DIG', 'schematic': {'filters': {'where_clause': {'AND': [{'pred_text': 'has_name', 'obj_text': 'hole '}]}}, 'text_span': 'hole '}}]}
> INFO:root:update_recent_entities []
> 2021-10-27 16:11:40,956 [sql_memory.py:227 - update_recent_entities() INFO]: update_recent_entities []
> INFO:root:Sending chat: I finished digging this.
> 2021-10-27 16:11:41,029 [craftassist_agent.py:347 - send_chat() INFO]: Sending chat: I finished digging this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.